Skip to content

add CLI argument --disable-workspace-trust #5638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

add CLI argument --disable-workspace-trust #5638

merged 1 commit into from
Oct 13, 2022

Conversation

kotborealis
Copy link
Contributor

Add CLI flag to disable workspace trust feature, as described in documentation:
https://code.visualstudio.com/docs/editor/workspace-trust

Fixes #5288

@kotborealis kotborealis requested a review from a team as a code owner October 10, 2022 18:49
@kotborealis kotborealis force-pushed the main branch 5 times, most recently from d01e368 to d8a5d5b Compare October 10, 2022 18:58
@kotborealis
Copy link
Contributor Author

Sorry for the mess with force-pushes, could not get commit signature right 😢

@jsjoeio jsjoeio self-assigned this Oct 10, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 10, 2022

Thank you! Do you mind adding or updating a test?

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 10, 2022

And if it's not too much trouble, can you post a video showing this working?

@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Merging #5638 (34be40c) into main (ba68656) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5638   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          30       30           
  Lines        1678     1678           
  Branches      366      366           
=======================================
  Hits         1217     1217           
  Misses        398      398           
  Partials       63       63
Impacted Files Coverage Δ
src/node/cli.ts 91.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba68656...34be40c. Read the comment docs.

@kotborealis
Copy link
Contributor Author

Okay, I'll find some time today for tests and video 👍🏻

@kotborealis
Copy link
Contributor Author

kotborealis commented Oct 11, 2022 •
edited
Loading

Demo (youtube)
Sorry for screen tearing, drivers won't make friends with screen recorder; and for some reason github fails to attach video directly to this comment 😕

I also had to touch other e2e tests to pass --disable-workspace-trust, instead of setting it in config file.

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 13, 2022

That video was awesome!! Thanks for doing it. Looks great 🚀

jsjoeio
jsjoeio approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@kotborealis
add CLI argument --disable-workspace-trust
34be40c 
Add CLI flag to disable workspace trust feature, as
described in documentation:
https://code.visualstudio.com/docs/editor/workspace-trust

Add test for workspace trust argument.
@jsjoeio jsjoeio enabled auto-merge (squash) October 13, 2022 19:45
@jsjoeio jsjoeio merged commit f61ec4a into coder:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: Way to invoke code-server with --disable-workspace-trust option.
2 participants
@kotborealis @jsjoeio