Skip to content

Update the cloudflare tunnel description. #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Update the cloudflare tunnel description. #5614

merged 3 commits into from
Oct 7, 2022

Conversation

Moius
Copy link
Contributor

@Moius Moius commented Oct 2, 2022

Fixes #

@Moius Moius requested a review from a team as a code owner October 2, 2022 16:07

```shell
Host *.trycloudflare.com
HostName %h
User root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...could this have unintended consequences? @code-asher

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer to use a non-root user login in the local configuration file for security purposes. Also the username entered in vscode should be the same as the user in the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this should be the user that is running code-server and not root. Looks good to me. 👍

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #5614 (917e004) into main (b562d4a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5614   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          30       30           
  Lines        1678     1678           
  Branches      366      366           
=======================================
  Hits         1217     1217           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b562d4a...917e004. Read the comment docs.

@jsjoeio jsjoeio enabled auto-merge (squash) October 7, 2022 17:50
@jsjoeio jsjoeio merged commit b2f043a into coder:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants