Skip to content

feat: add doas support #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022
Merged

feat: add doas support #5600

merged 1 commit into from
Oct 4, 2022

Conversation

unknowndevQwQ
Copy link
Contributor

Some people may have some reason to drop sudo and switch to doas

Fixes #5599

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 29, 2022

I'm not familiar with doas. I did a quick search and it seems like it should be fine.

Are there any potential side effects of this?

@jsjoeio jsjoeio assigned jsjoeio and code-asher and unassigned jsjoeio Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #5600 (c39a6f6) into main (77bbed4) will not change coverage.
The diff coverage is n/a.

❗ Current head c39a6f6 differs from pull request most recent head 9bf1ee2. Consider uploading reports for the commit 9bf1ee2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5600   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           
Impacted Files Coverage Δ
src/node/wrapper.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77bbed4...9bf1ee2. Read the comment docs.

@code-asher code-asher marked this pull request as ready for review September 29, 2022 17:26
@code-asher code-asher requested a review from a team as a code owner September 29, 2022 17:26
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems chill to me, could we add doas to the echo a few lines lower? So we would have Please install doas, sudo, or su.

@unknowndevQwQ
Copy link
Contributor Author

Seems chill to me, could we add doas to the echo a few lines lower? So we would have Please install doas, sudo, or su.

sure

@unknowndevQwQ unknowndevQwQ marked this pull request as draft September 30, 2022 16:16
@unknowndevQwQ unknowndevQwQ force-pushed the patch-2 branch 3 times, most recently from e3876b0 to ddb49ce Compare September 30, 2022 16:21
@unknowndevQwQ unknowndevQwQ marked this pull request as ready for review September 30, 2022 16:22
Some people may have some reason to drop sudo and switch to doas
@jsjoeio jsjoeio enabled auto-merge (squash) October 4, 2022 16:25
@jsjoeio jsjoeio merged commit 3a9eb31 into coder:main Oct 4, 2022
@unknowndevQwQ unknowndevQwQ deleted the patch-2 branch October 5, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: add doas support
3 participants