Skip to content

fix: add node to path #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 29, 2022
Merged

fix: add node to path #5598

merged 13 commits into from
Sep 29, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 28, 2022

  • fix: remove deprecated symlink
  • refactor: remove deprecation notice
  • fixup! refactor: remove deprecation notice
  • fix: add node to path

@jsjoeio jsjoeio requested a review from a team as a code owner September 28, 2022 21:36
@jsjoeio jsjoeio changed the title jsjoeio/fixes fix: add node to path Sep 28, 2022
@jsjoeio jsjoeio self-assigned this Sep 28, 2022
@jsjoeio jsjoeio requested a review from code-asher September 28, 2022 22:01
@jsjoeio jsjoeio temporarily deployed to npm September 28, 2022 22:56 Inactive
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #5598 (acf660d) into main (8629d6a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5598   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           
Impacted Files Coverage Δ
src/node/wrapper.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8629d6a...acf660d. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 28, 2022

✨ code-server dev build published to npm for PR #5598!

  • Last publish status: success
  • Commit: acf660d

To install in a local project, run:

npm install @coder/code-server-pr@5598

To install globally, run:

npm install -g @coder/code-server-pr@5598

@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 15:25 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 16:20 Inactive
@jsjoeio jsjoeio requested a review from code-asher September 29, 2022 16:46
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 17:08 Inactive
@jsjoeio jsjoeio enabled auto-merge (squash) September 29, 2022 18:07
@jsjoeio jsjoeio requested a review from code-asher September 29, 2022 18:07
@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 18:17 Inactive
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Sep 29, 2022

Bump @code-asher ready for another review!

@jsjoeio jsjoeio temporarily deployed to npm September 29, 2022 21:01 Inactive
@jsjoeio jsjoeio merged commit 3ac2307 into main Sep 29, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fixes branch September 29, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants