Skip to content

fix: fix can't run it as expected in freebsd #5595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

unknowndevQwQ
Copy link
Contributor

In freebsd, su -c expects a login class argument instead of a command, if -c is preceded by a username, then -c and the arguments that follow will be passed as shell arguments

Fixes #5594

In freebsd, su -c expects a login class argument instead of a command, if -c is preceded by a username, then -c and the arguments that follow will be passed as shell arguments
@unknowndevQwQ
Copy link
Contributor Author

The question I'm confused about is why the -l/- option is added to the su command, what is it to avoid?

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if there was a good reason for the - but I think it is safe to remove.

Thank you for the fix!

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #5595 (9adc83b) into main (acdbefb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5595   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdbefb...9adc83b. Read the comment docs.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 28, 2022

You can ignore the security audit failure since it's unrelated to your PR.

@code-asher code-asher marked this pull request as ready for review September 28, 2022 20:48
@code-asher code-asher requested a review from a team as a code owner September 28, 2022 20:48
@code-asher code-asher enabled auto-merge (squash) September 28, 2022 20:49
@code-asher code-asher merged commit b6aeb4b into coder:main Sep 28, 2022
@unknowndevQwQ unknowndevQwQ deleted the patch-2 branch September 29, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: install.sh does not work as expected on freebsd
3 participants