Skip to content

Set RPM Upgrade Flag #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Set RPM Upgrade Flag #5588

merged 1 commit into from
Sep 26, 2022

Conversation

shawnweeks
Copy link
Contributor

@shawnweeks shawnweeks commented Sep 25, 2022

Fixes #5383, RPM installs should use the -U flag instead of -i because -U will upgrade instead of failing if code-server is already installed.

@shawnweeks shawnweeks requested a review from a team as a code owner September 25, 2022 16:45
@jsjoeio jsjoeio self-assigned this Sep 26, 2022
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great improvement to me! 🙌🏼 Thank you!

@jsjoeio jsjoeio requested a review from code-asher September 26, 2022 17:35
@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 26, 2022

Let's get 👍🏼 from @code-asher too then we can merge.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #5588 (8048339) into main (3256157) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5588   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3256157...8048339. Read the comment docs.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out and it worked perfectly. 👍

@jsjoeio jsjoeio merged commit 3264187 into coder:main Sep 26, 2022
@shawnweeks shawnweeks deleted the fix-issue-5383 branch September 28, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RPM Install Should Include Upgrade Flag
3 participants