Skip to content

chore(ci): move platform steps to release #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 27, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 23, 2022

Testing Plan

  1. Download npm-package from CI
  2. Unzip
  3. cp -r node_modules over
  4. run e2e tests: CODE_SERVER_TEST_ENTRY=./release yarn test:e2e

image

Run Draft Release workflow manually and double-check it still works: https://github.com/coder/code-server/actions/runs/3137843307

https://github.com/coder/code-server/releases/tag/untagged-75fb9412785a52dd69a5

Fixes #

@jsjoeio jsjoeio self-assigned this Sep 23, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Sep 23, 2022

point it to ./release instead for when you switch to npm. copy over the node_modules for lib and node_modules.

run: KEEP_MODULES=1 yarn release

we'll have to test this and run draft workflow and see if the native tests still work okay. if they do, we're good. otherwise, we'll have to make a separate artifact or something.

@jsjoeio jsjoeio temporarily deployed to npm September 26, 2022 21:10 Inactive
@github-actions
Copy link

github-actions bot commented Sep 26, 2022

✨ code-server dev build published to npm for PR #5587!

  • Last publish status: success
  • Commit: 4ef8e6e

To install in a local project, run:

npm install @coder/code-server-pr@5587

To install globally, run:

npm install -g @coder/code-server-pr@5587

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #5587 (4ef8e6e) into main (3264187) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5587   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3264187...4ef8e6e. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm September 26, 2022 21:35 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 26, 2022 21:42 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 26, 2022 22:09 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 27, 2022 16:38 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 27, 2022 16:57 Inactive
@jsjoeio jsjoeio temporarily deployed to npm September 27, 2022 17:21 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review September 27, 2022 17:32
@jsjoeio jsjoeio requested a review from a team as a code owner September 27, 2022 17:32
@jsjoeio jsjoeio temporarily deployed to npm September 27, 2022 18:01 Inactive
@jsjoeio jsjoeio enabled auto-merge (squash) September 27, 2022 18:07
@jsjoeio jsjoeio merged commit 05289d3 into main Sep 27, 2022
@jsjoeio jsjoeio deleted the jsjoeio/refactor-build-release branch September 27, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants