Skip to content

fix(ci): specify ref in aur publish job #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022
Merged

fix(ci): specify ref in aur publish job #5550

merged 1 commit into from
Sep 9, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 9, 2022

I've noticed the last two times the aur job runs and opens a PR into code-server-aur, there are conflicts. It seems like it's not getting the latest commits. Based on this, I think specifying ref may help.

I do not see any downsides to adding this even if this doesn't fix it.

@jsjoeio jsjoeio requested a review from a team as a code owner September 9, 2022 22:29
@jsjoeio jsjoeio self-assigned this Sep 9, 2022
@jsjoeio jsjoeio added this to the September 2022 milestone Sep 9, 2022
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that makes sense!

@jsjoeio jsjoeio temporarily deployed to npm September 9, 2022 22:34 Inactive
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

✨ code-server dev build published to npm for PR #5550!

  • Last publish status: success
  • Commit: b0c0d0e

To install in a local project, run:

npm install @coder/code-server-pr@5550

To install globally, run:

npm install -g @coder/code-server-pr@5550

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #5550 (b0c0d0e) into main (04f1080) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5550   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f1080...b0c0d0e. Read the comment docs.

@jsjoeio jsjoeio enabled auto-merge (squash) September 9, 2022 22:36
@jsjoeio jsjoeio merged commit dbe87c5 into main Sep 9, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-aur branch September 9, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants