Skip to content

chore: add npm followup comment #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

chore: add npm followup comment #5541

merged 2 commits into from
Sep 6, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 6, 2022

  • chore: use npm ci in build-standalone-release
  • docs: add comment to npm-postinstall.sh

followup from #5533

@jsjoeio jsjoeio requested a review from a team as a code owner September 6, 2022 18:51
@jsjoeio jsjoeio self-assigned this Sep 6, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Sep 6, 2022

cc @edvincent

@jsjoeio jsjoeio added this to the September 2022 milestone Sep 6, 2022
@jsjoeio jsjoeio added chore Related to maintenance or clean up rebase when passing labels Sep 6, 2022
@jsjoeio jsjoeio temporarily deployed to npm September 6, 2022 18:57 Inactive
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

✨ code-server dev build published to npm for PR #5541!

  • Last publish status: success
  • Commit: 9b889f4

To install in a local project, run:

npm install @coder/code-server-pr@5541

To install globally, run:

npm install -g @coder/code-server-pr@5541

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #5541 (175fa0e) into main (da03a64) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5541   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da03a64...175fa0e. Read the comment docs.

@edvincent
Copy link
Contributor

Yeah... npm ci still needs some looking around... Which is why I was suggesting to follow-up on this as I have already gathered some knowledge around npm these last couple of months 😂

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Sep 6, 2022

Yeah... npm ci still needs some looking around... Which is why I was suggesting to follow-up on this as I have already gathered some knowledge around npm these last couple of months 😂

LOL darn it! Why can't anything ever be easy... okay let me drop the npm ci commit and at least add that comment.

@jsjoeio jsjoeio changed the title jsjoeio/npm fixups chore: add npm followup comment Sep 6, 2022
@jsjoeio jsjoeio temporarily deployed to npm September 6, 2022 20:13 Inactive
@jsjoeio jsjoeio merged commit 64822d0 into main Sep 6, 2022
@jsjoeio jsjoeio deleted the jsjoeio/npm-fixups branch September 6, 2022 20:34
@jsjoeio jsjoeio temporarily deployed to npm September 6, 2022 20:39 Inactive
@jsjoeio jsjoeio modified the milestones: September 2022, v4.7.0 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants