Skip to content

chore(testing): remove install/list tests #5441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 10, 2022

Now that we have a test for --help which checks to make sure native
modules are working as expected, we don't need the --install-extension
test or the --list-extensions test.

We can also remove the .vsix fixture since we're not using that
either.

Fixes #

Now that we have a test for `--help` which checks to make sure native
modules are working as expected, we don't need the `--install-extension`
test or the `--list-extensions` test.

We can also remove the `.vsix` fixture since we're not using that
either.
@jsjoeio jsjoeio requested a review from a team August 10, 2022 21:42
@jsjoeio jsjoeio self-assigned this Aug 10, 2022
@jsjoeio jsjoeio added this to the August 2022 milestone Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #5441 (909f741) into main (91589fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5441   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91589fd...909f741. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm August 10, 2022 21:47 Inactive
@github-actions
Copy link

✨ code-server dev build published to npm for PR #5441!

  • Last publish status: success
  • Commit: 909f741

To install in a local project, run:

npm install @coder/code-server-pr@5441

To install globally, run:

npm install -g @coder/code-server-pr@5441

@jsjoeio jsjoeio temporarily deployed to npm August 10, 2022 22:47 Inactive
@repo-ranger repo-ranger bot merged commit c69f2c6 into main Aug 10, 2022
@repo-ranger repo-ranger bot deleted the jsjoeio/rm-test branch August 10, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants