Skip to content

replace inline svgs with icon_path #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022
Merged

replace inline svgs with icon_path #5395

merged 2 commits into from
Aug 1, 2022

Conversation

antonkor
Copy link

@antonkor antonkor commented Aug 1, 2022

replace inline svgs with icon_path

related to https://github.com/coder/coder.com/pull/103

@antonkor antonkor requested review from ammario and a team and removed request for a team August 1, 2022 10:15
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

✨ code-server docs for PR #5395 is ready! It will be updated on every commit.

@antonkor antonkor temporarily deployed to npm August 1, 2022 10:19 Inactive
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

✨ code-server dev build published to npm for PR #5395!

  • Last publish status: success
  • Commit: 785e729

To install in a local project, run:

npm install @coder/code-server-pr@5395

To install globally, run:

npm install -g @coder/code-server-pr@5395

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #5395 (785e729) into main (da9e72c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5395   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files          30       30           
  Lines        1672     1672           
  Branches      366      366           
=======================================
  Hits         1211     1211           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da9e72c...785e729. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better. Thank you!

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 1, 2022

image

Checked preview - all looks good to me!

@jsjoeio jsjoeio enabled auto-merge (squash) August 1, 2022 19:59
@jsjoeio jsjoeio self-assigned this Aug 1, 2022
@jsjoeio jsjoeio added this to the July 2022 milestone Aug 1, 2022
@jsjoeio jsjoeio temporarily deployed to npm August 1, 2022 20:03 Inactive
@jsjoeio jsjoeio merged commit b2ed6b8 into main Aug 1, 2022
@jsjoeio jsjoeio deleted the sidebar-icons branch August 1, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants