Skip to content

define extraInitContainers #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2022
Merged

define extraInitContainers #5385

merged 1 commit into from
Aug 1, 2022

Conversation

masterkain
Copy link

otherwise custom values will not be picked up by Flux/Helm

otherwise custom values will not be picked up by Flux/Helm
@code-asher code-asher requested a review from a team August 1, 2022 15:30
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Looks good to me. I see we have the same block in the documentation but seems like a good idea to me to have it in the config as well.

@code-asher code-asher merged commit 3054f09 into coder:main Aug 1, 2022
@masterkain
Copy link
Author

not sure what's going on but extraInitContainers still isn't picked up by the deployment (using git chart version with the merged change), needs further investigation

@masterkain
Copy link
Author

masterkain commented Aug 2, 2022

ok, that might be this https://github.com/coder/code-server/blob/main/ci/helm-chart/templates/deployment.yaml#L35-L36

initContainers is wrapped in a volumePermissions and persistence conditional, so if I have persistence disabled extraInitContainers won't make it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants