Skip to content

fix: remove default memory limit #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

code-asher
Copy link
Member

Having NODE_OPTIONS set is unexpected and although the later flag should
override the previous flag it is not certain that will always be the
case.

Also some users are having issues with the 2 GB limit.

Having NODE_OPTIONS set is unexpected and although the later flag should
override the previous flag it is not certain that will always be the
case.

Also some users are having issues with the 2 GB limit.
@code-asher code-asher requested a review from a team July 18, 2022 21:28
@jsjoeio jsjoeio self-assigned this Jul 18, 2022
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember hearing about others run into issues with this. I agree that it makes sense to remove this and let users decide what memory limit they want to set.

@jsjoeio jsjoeio added this to the 4.5.1 milestone Jul 18, 2022
@jsjoeio jsjoeio merged commit 592973c into coder:main Jul 18, 2022
@code-asher code-asher deleted the remove-default-memory-limit branch July 18, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants