-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix(terminal): use window.location to work when served NOT on root path #5332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ code-server docs for PR #5332 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5332 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 30 30
Lines 1671 1671
Branches 367 367
=======================================
Hits 1211 1211
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
0e5df64
to
2b339bc
Compare
When using `window.location.origin` to create a new URL for loading web packages, it constructs a URL that is not relative, leading to the terminal breaking when code-server is served not via the root (i.e. /ide instead of /).
2b339bc
to
eadad9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, nice catch.
Description
We made a change in
workbench-dev.html
but forgot to make it inworkbench.html
. This fixes the Integrated Terminal to work when code-server is served NOT on the root path (i.e. accessed at/vscode
instead of/
).Fixes #5321