Skip to content

fix: install nfpm straight from GitHub #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2022

Conversation

code-asher
Copy link
Member

install.goreleaser.com appears to no longer be available.

@code-asher code-asher requested a review from a team May 20, 2022 18:23
install.goreleaser.com appears to no longer be available.
@jsjoeio jsjoeio added this to the May 2022 milestone May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #5214 (1719434) into main (d3f58f9) will not change coverage.
The diff coverage is n/a.

❗ Current head 1719434 differs from pull request most recent head a5197d1. Consider uploading reports for the commit a5197d1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5214   +/-   ##
=======================================
  Coverage   71.73%   71.73%           
=======================================
  Files          30       30           
  Lines        1663     1663           
  Branches      367      367           
=======================================
  Hits         1193     1193           
  Misses        403      403           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f58f9...a5197d1. Read the comment docs.

This might have made it so we got the right error rather than erroring
on the envsubst step.
@code-asher code-asher enabled auto-merge (squash) May 20, 2022 19:35
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your attention to detail on these kinds of things. You are truly a craftsman 🪓

@code-asher code-asher merged commit 5d47282 into coder:main May 20, 2022
@code-asher code-asher deleted the fix-nfpm-install branch May 20, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants