Skip to content

refactor(util): remove unused isObject function #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 9, 2022

Jest reported uncovered code for this function block. I did a search and couldn't find it used anywhere so decided we should remove it.

Related to #5149 #5153

@jsjoeio jsjoeio requested a review from a team May 9, 2022 23:06
@jsjoeio jsjoeio self-assigned this May 9, 2022
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 9, 2022
@jsjoeio jsjoeio added this to the May 2022 milestone May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

✨ code-server docs for PR #5183 is ready! It will be updated on every commit.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #5183 (b29af6c) into main (3207bfd) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head b29af6c differs from pull request most recent head 61a7ffd. Consider uploading reports for the commit 61a7ffd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5183      +/-   ##
==========================================
+ Coverage   71.79%   71.81%   +0.02%     
==========================================
  Files          30       30              
  Lines        1691     1689       -2     
  Branches      375      374       -1     
==========================================
- Hits         1214     1213       -1     
  Misses        408      408              
+ Partials       69       68       -1     
Impacted Files Coverage Δ
src/node/util.ts 82.58% <ø> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3207bfd...61a7ffd. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm May 9, 2022 23:11 Inactive
@github-actions
Copy link

github-actions bot commented May 9, 2022

✨ code-server dev build published to npm for PR #5183!

  • Last publish status: success
  • Commit: 61a7ffd

To install in a local project, run:

npm install @coder/code-server-pr@5183

To install globally, run:

npm install -g @coder/code-server-pr@5183

@jsjoeio jsjoeio enabled auto-merge (squash) May 9, 2022 23:19
@jsjoeio jsjoeio temporarily deployed to npm May 10, 2022 00:07 Inactive
@jsjoeio jsjoeio merged commit cd78f32 into main May 10, 2022
@jsjoeio jsjoeio deleted the jsjoeio/rm-isObject branch May 10, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants