Skip to content

fix(update): add OrEqual to update.checked test #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 6, 2022

Fixes a flaky test in update.test.ts

@jsjoeio jsjoeio requested a review from a team May 6, 2022 16:12
@github-actions
Copy link

github-actions bot commented May 6, 2022

✨ code-server docs for PR #5171 is ready! It will be updated on every commit.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #5171 (2023d06) into main (66a3643) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5171   +/-   ##
=======================================
  Coverage   71.73%   71.73%           
=======================================
  Files          30       30           
  Lines        1691     1691           
  Branches      375      375           
=======================================
  Hits         1213     1213           
  Misses        409      409           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a3643...2023d06. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm May 6, 2022 16:20 Inactive
@github-actions
Copy link

github-actions bot commented May 6, 2022

✨ code-server dev build published to npm for PR #5171!

  • Last publish status: success
  • Commit: 2023d06

To install in a local project, run:

npm install @coder/code-server-pr@5171

To install globally, run:

npm install -g @coder/code-server-pr@5171

Comment on lines +134 to +135
expect(update.checked).toBeGreaterThanOrEqual(now)
expect(update.checked).toBeLessThanOrEqual(Date.now())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@jsjoeio jsjoeio enabled auto-merge (squash) May 6, 2022 16:31
@jsjoeio jsjoeio temporarily deployed to npm May 6, 2022 16:33 Inactive
@jsjoeio jsjoeio merged commit 5a5798e into main May 6, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-flaky-test2 branch May 6, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants