fix: webviews failing to load the iframe HTML #5103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code added in 1.65.0 broke webviews when you are hosting them from the same domain.
code-asher
changed the title
Don't worry, I will take care of that later! (Or make tickets and either of us can do it, planning to do it for all patches). |
jsjoeio
approved these changes
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #5103 +/- ##
=======================================
Coverage 71.33% 71.33%
=======================================
Files 30 30
Lines 1685 1685
Branches 374 374
=======================================
Hits 1202 1202
Misses 413 413
Partials 70 70 Continue to review full report at Codecov.
|
I think this is more true to the spirit of the code (it is trying to authenticate cross-origin requests so if it is not cross-origin we can skip it).
jsjoeio
approved these changes
Apr 14, 2022
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
Code added in 1.65.0 broke webviews when you are hosting them from the same domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code added in 1.65.0 broke webviews when you are hosting them from the
same domain.
Really should add an e2e test as well but I do not have the time right now.