Skip to content

release: 4.3.0 #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

release: 4.3.0 #5096

wants to merge 3 commits into from

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 13, 2022

This PR is to generate a new release of code-server at 4.3.0

Screenshot

npm build: tested on coder and works as expected 👍🏼
image

TODOs

Follow "Publishing a release" steps in ci/README.md

  • test npm build
  • test built-in extensions
  • publish release and merge PR
  • update the AUR package

Fixes #5021

@jsjoeio jsjoeio self-assigned this Apr 13, 2022
@jsjoeio jsjoeio requested a review from a team April 13, 2022 17:28
@github-actions
Copy link

github-actions bot commented Apr 13, 2022

✨ code-server docs for PR #5096 is ready! It will be updated on every commit.

@jsjoeio jsjoeio temporarily deployed to npm April 13, 2022 17:33 Inactive
@github-actions
Copy link

github-actions bot commented Apr 13, 2022

✨ code-server dev build published to npm for PR #5096!

  • Last publish status: success
  • Commit: a5d3212

To install in a local project, run:

npm install @coder/code-server-pr@5096

To install globally, run:

npm install -g @coder/code-server-pr@5096

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #5096 (3694672) into main (e7e6c16) will not change coverage.
The diff coverage is n/a.

❗ Current head 3694672 differs from pull request most recent head a5d3212. Consider uploading reports for the commit a5d3212 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5096   +/-   ##
=======================================
  Coverage   71.33%   71.33%           
=======================================
  Files          30       30           
  Lines        1685     1685           
  Branches      374      374           
=======================================
  Hits         1202     1202           
  Misses        413      413           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e6c16...a5d3212. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm April 13, 2022 17:49 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review April 13, 2022 18:05
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Apr 13, 2022

Hmm...looks like image preview is failing
image

Detailed view of error:
image

Line where it's throwing: https://github.com/microsoft/vscode/blob/c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1/src/vs/workbench/contrib/webview/browser/pre/service-worker.js#L235

This was introduce in this commit: microsoft/vscode@9f867c3

commit message:

While I'm not 100% about this, I think microsoft/vscode@66b6adf causes resourses to occasionally not load

It's interesting because the first time, it did load my image but then every subsequent load failed. I'll need to further investigate.

Notes

So it turns out there is no clientId on the event. Time to figure out why.

image

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the branch name needs a v for the download action to pick up the artifacts

@jsjoeio jsjoeio closed this Apr 13, 2022
@jsjoeio jsjoeio deleted the 4.3.0 branch April 13, 2022 21:45
@jsjoeio jsjoeio mentioned this pull request Apr 13, 2022
6 tasks
@jsjoeio jsjoeio temporarily deployed to npm April 13, 2022 21:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore]: release 4.3.0
2 participants