-
Notifications
You must be signed in to change notification settings - Fork 5.9k
release: 4.3.0 #5096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 4.3.0 #5096
Conversation
✨ code-server docs for PR #5096 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5096 +/- ##
=======================================
Coverage 71.33% 71.33%
=======================================
Files 30 30
Lines 1685 1685
Branches 374 374
=======================================
Hits 1202 1202
Misses 413 413
Partials 70 70 Continue to review full report at Codecov.
|
Hmm...looks like image preview is failing Line where it's throwing: https://github.com/microsoft/vscode/blob/c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1/src/vs/workbench/contrib/webview/browser/pre/service-worker.js#L235 This was introduce in this commit: microsoft/vscode@9f867c3 commit message:
It's interesting because the first time, it did load my image but then every subsequent load failed. I'll need to further investigate. Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the branch name needs a v
for the download action to pick up the artifacts
This PR is to generate a new release of
code-server
at4.3.0
Screenshot
npm build: tested on coder and works as expected 👍🏼

TODOs
Follow "Publishing a release" steps in
ci/README.md
Fixes #5021