Skip to content

chore: remove file ext. from LICENSE #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2022
Merged

chore: remove file ext. from LICENSE #5070

merged 5 commits into from
Apr 7, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 6, 2022

This removes the file extension .txt from the LICENSE file to be consistent with Coder's open source organization standards.

Fixes N/A

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Apr 6, 2022
@jsjoeio jsjoeio added this to the April 2022 milestone Apr 6, 2022
@jsjoeio jsjoeio self-assigned this Apr 6, 2022
@jsjoeio jsjoeio requested a review from a team April 6, 2022 18:13
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

✨ code-server docs for PR #5070 is ready! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #5070 (c11ae6f) into main (38e57a3) will not change coverage.
The diff coverage is n/a.

❗ Current head c11ae6f differs from pull request most recent head 81d3a36. Consider uploading reports for the commit 81d3a36 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5070   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e57a3...81d3a36. Read the comment docs.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a build step that needs updating.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Apr 6, 2022

Looks like there is a build step that needs updating.

Now that is something I didn't expect - yay CI for catching that! I'll fix this :)

@jsjoeio jsjoeio requested a review from code-asher April 6, 2022 22:36
@jsjoeio jsjoeio temporarily deployed to npm April 6, 2022 22:49 Inactive
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

✨ code-server dev build published to npm for PR #5070!

  • Last publish status: success
  • Commit: 81d3a36

To install in a local project, run:

npm install @coder/code-server-pr@5070

To install globally, run:

npm install -g @coder/code-server-pr@5070

@jsjoeio jsjoeio requested a review from code-asher April 7, 2022 15:33
@jsjoeio jsjoeio temporarily deployed to npm April 7, 2022 15:38 Inactive
@jsjoeio jsjoeio merged commit f0bfd3b into main Apr 7, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-license branch April 7, 2022 17:36
@jsjoeio jsjoeio modified the milestones: April 2022, 4.3.0 Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* chore: remove file ext. from LICENSE

* fixup!: update LICENSE in missing places

* Revert "fixup!: update LICENSE in missing places"

This reverts commit baa47b6.

* fixup!: update LICENSE in build-release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants