refactor(brew-bump): fix homebrew bump script #5025
Conversation
|
✨ code-server docs for PR #5025 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5025 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 30 30
Lines 1683 1683
Branches 373 373
=======================================
Hits 1200 1200
Misses 413 413
Partials 70 70 Continue to review full report at Codecov.
|
| needs: npm | ||
| runs-on: macos-latest | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
🛠️ Homebrew runs on Linux and Linux runners are more available (anecdotally) than macOS runners. Maybe it'll save some time.
| git config user.name github-actions | ||
| git config user.email github-actions@github.com | ||
| git config user.name cdrci | ||
| git config user.email opensource@coder.com |
There was a problem hiding this comment.
Wasn't sure if I should use a real email or a fake one. Opted for a legit one in case something happened with this PR and someone needed to contact us 🤷🏼♂️
| export HOMEBREW_GITHUB_API_TOKEN="$HOMEBREW_GITHUB_API_TOKEN" | ||
| export GIT_ASKPASS="$PATH_TO_GIT_ASKPASS" | ||
| git push "https://[email protected]/$GITHUB_USERNAME/$REPO.git" --all | ||
|
|
There was a problem hiding this comment.
Based on this comment, using that setup homebrew action means we shouldn't have to keep a fork up-to-date and in testing things, it worked.
And to confirm, you can see in the PR description that brew bump-formula-pr with --dry-run worked even though cdrci's fork is behind
There was a problem hiding this comment.
Wow, great news! I guess the issue we ran into was an edge case.
This reverts commit 2f7a361.
|
bump @code-asher |
| export HOMEBREW_GITHUB_API_TOKEN="$HOMEBREW_GITHUB_API_TOKEN" | ||
| export GIT_ASKPASS="$PATH_TO_GIT_ASKPASS" | ||
| git push "https://[email protected]/$GITHUB_USERNAME/$REPO.git" --all | ||
|
|
There was a problem hiding this comment.
Wow, great news! I guess the issue we ran into was an edge case.
* fix: source lib.sh in docker-buildx-push for tagging version * chore: use ubuntu and update git config homebrew job * refactor: simplify brew-bump.sh script * Revert "fix: source lib.sh in docker-buildx-push for tagging version" This reverts commit 2f7a361.
This PR should fix the
brew-bumpscript that runs when we publish releases.Testing
I tested this in a separate PR with the
--dry-runflag and received no errors. I didn't try without--dry-runbut can separately if requested.Here is how I tested: https://github.com/coder/code-server/pull/5023/files
Fixes #4950