Skip to content

fix: source lib.sh in docker-buildx-push for tagging version #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 23, 2022

I didn't realize the Docker workflow needed VERSION to publish a tag. This fixes that workflow.

See #5022 (comment) for more context

Todos

  • manually dispatch Docker publish workflow to push 4.2.0 version

Fixes #5022

@jsjoeio jsjoeio added the ci Issues related to ci label Mar 23, 2022
@jsjoeio jsjoeio self-assigned this Mar 23, 2022
@jsjoeio jsjoeio requested a review from a team March 23, 2022 22:15
@github-actions
Copy link

✨ code-server docs for PR #5024 is ready! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #5024 (2f7a361) into main (ba1ddbd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5024   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1ddbd...2f7a361. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm March 23, 2022 22:20 Inactive
@jsjoeio jsjoeio merged commit e1c1ba8 into main Mar 24, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-docker-script branch March 24, 2022 16:33
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No 4.2.0 Tag on docker hub
2 participants