feat(ci): publish dev builds to @coder/code-server-pr

.github/workflows/ci.yaml

@@ -205,6 +205,15 @@ jobs:
           name: "npm-package"
           path: release-npm-package
 
+      # NOTE@jsjoeio - we need to make sure we're using
+      # v7 or higher of the npm CLI because it's used
+      # in the yarn publish:npm script in development builds
+      # to modify package.json name.
+      - name: Install Node & npm v8
+        uses: actions/setup-node@v3
+        with:
+          node-version: "16.14.0"
+
       - name: Run ./ci/steps/publish-npm.sh
         run: yarn publish:npm
         env:

.github/workflows/npm-brew.yaml

@@ -29,6 +29,15 @@ jobs:
           name: "npm-package"
           path: release-npm-package
 
+      # NOTE@jsjoeio - we need to make sure we're using
+      # v7 or higher of the npm CLI because it's used
+      # in the yarn publish:npm script in development builds
+      # to modify package.json name.
+      - name: Install Node & npm v8
+        uses: actions/setup-node@v3
+        with:
+          node-version: "16.14.0"
+
       - name: Publish npm package and tag with "latest"
         run: yarn publish:npm
         env:

ci/steps/publish-npm.sh

@@ -51,6 +51,27 @@ main() {
     exit 1
   fi
 
+  # Check that we're using at least v7 of npm CLI
+  if ! command -v npm &> /dev/null; then
+    echo "Couldn't find the npm CLI"
+    echo "Are you sure you have it installed?"
+    echo "Please check again with: npm -v"
+    echo "And re-run the script."
+    exit 1
+  fi
+
+  # NOTE@jsjoeio - this needs to run inside the release dir
+  # where the package.json for code-server is.
+  pushd release
+  if npm pkg get name && [ $? -eq 1 ]; then
+    echo "Couldn't get package.json name with 'npm pkg get name'"
+    echo "This usually means npm v7 or higher could not be found."
+    echo "We use this to modify the package.json name for dev builds."
+    echo "Please upgrade to npm v7 or higher and re-run the script."
+    exit 1
+  fi
+  popd
+
   # This allows us to publish to npm in CI workflows
   if [[ ${CI-} ]]; then
     echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
@@ -85,6 +106,9 @@ main() {
   # Ignore symlink when publishing npm package
   # See: https://github.com/coder/code-server/pull/3935
   echo "node_modules.asar" > release/.npmignore
+  # We use this to set the name of the package in the
+  # package.json
+  PACKAGE_NAME="code-server"
 
   # NOTES:@jsjoeio
   # We only need to run npm version for "development" and "staging".
@@ -112,22 +136,30 @@ main() {
       # Source: https://github.com/actions/checkout/issues/58#issuecomment-614041550
       PR_NUMBER=$(echo "$GITHUB_REF" | awk 'BEGIN { FS = "/" } ; { print $3 }')
       NPM_VERSION="$VERSION-$PR_NUMBER-$COMMIT_SHA"
+      PACKAGE_NAME="@coder/code-server-pr"
       # This means the npm version will be tagged with "<pr number>"
       # and installed when a user runs `yarn install code-server@<pr number>`
       NPM_TAG="$PR_NUMBER"
     fi
 
     echo "using tag: $NPM_TAG"
+    echo "using package name: $PACKAGE_NAME"
 
     # We modify the version in the package.json
     # to be the current version + the PR number + commit SHA
     # or we use current version + beta + commit SHA
     # Example: "version": "4.0.1-4769-ad7b23cfe6ffd72914e34781ef7721b129a23040"
     # Example: "version": "4.0.1-beta-ad7b23cfe6ffd72914e34781ef7721b129a23040"
     pushd release
-    # NOTE:@jsjoeio
+    # NOTE@jsjoeio
     # I originally tried to use `yarn version` but ran into issues and abandoned it.
     npm version "$NPM_VERSION"
+    # NOTE@jsjoeio
+    # Use the development package name
+    # This is so we don't clutter the code-server versions on npm
+    # with development versions.
+    # Requires npm Version 7.x or higher
+    npm pkg set name="$PACKAGE_NAME"
     popd
   fi
 
@@ -141,7 +173,10 @@ main() {
     return
   fi
 
-  yarn publish --non-interactive release --tag "$NPM_TAG"
+  # NOTE@jsjoeio
+  # Since the dev builds are scoped to @coder
+  # We pass --access public to ensure npm knows it's not private.
+  yarn publish --non-interactive release --tag "$NPM_TAG" --access public
 }
 
 main "$@"