Skip to content

chore: add permissions trivy-docker #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 7, 2022

Looks like I didn't give this workflow the right permissions: https://github.com/coder/code-server/runs/5432361797?check_suite_focus=true

I am not sure if actions needs write permissions or if security needs write permissions so I added it to both.

Fixes N/A

@jsjoeio jsjoeio added this to the March 2022 milestone Mar 7, 2022
@jsjoeio jsjoeio self-assigned this Mar 7, 2022
@jsjoeio jsjoeio requested a review from a team March 7, 2022 20:50
@jsjoeio jsjoeio temporarily deployed to CI March 7, 2022 20:51 Inactive
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #4957 (5b2b8cd) into main (643ef13) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b2b8cd differs from pull request most recent head b6c3297. Consider uploading reports for the commit b6c3297 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4957   +/-   ##
=======================================
  Coverage   70.54%   70.54%           
=======================================
  Files          29       29           
  Lines        1677     1677           
  Branches      371      371           
=======================================
  Hits         1183     1183           
  Misses        420      420           
  Partials       74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643ef13...b6c3297. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm March 7, 2022 21:00 Inactive
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

✨ Coder.com for PR #4957 deployed! It will be updated on every commit.

@jsjoeio jsjoeio requested a review from jawnsy March 8, 2022 17:22
@jsjoeio jsjoeio temporarily deployed to CI March 8, 2022 17:22 Inactive
@jsjoeio jsjoeio temporarily deployed to npm March 8, 2022 17:31 Inactive
@jsjoeio jsjoeio temporarily deployed to npm March 8, 2022 19:26 Inactive
@jsjoeio jsjoeio merged commit 3b93a86 into main Mar 8, 2022
@jsjoeio jsjoeio deleted the jsjoeio/update-trivy-permissions branch March 8, 2022 20:19
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* chore: add permissions trivy-docker

* Update .github/workflows/trivy-docker.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants