fix: re-enable trivvy docker scan #4943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
added
security
Codecov Report
@@ Coverage Diff @@
## main #4943 +/- ##
=======================================
Coverage 70.30% 70.30%
=======================================
Files 29 29
Lines 1677 1677
Branches 371 371
=======================================
Hits 1179 1179
Misses 424 424
Partials 74 74 Continue to review full report at Codecov.
|
|
✨ Coder.com for PR #4943 deployed! It will be updated on every commit.
|
jsjoeio
force-pushed
the
jsjoeio/fix-trivvy-docker
branch
from
f78ac6f to
737df7b
Compare
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* fix: re-enable trivvy docker scan * wip * fixup * fixup * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the trivy Docker scan as part of our CI pipeline. With this, we will have trivy do a security check on our Docker image tagged
latestso that we can catch any security vulnerabilities.Testing
Example scan: https://github.com/coder/code-server/runs/5428919398?check_suite_focus=true
Previous Context
@code-asher I were chatting about this. We want the scan to run on
latestinstead of the local build since the local build will use the newest dependencies. Instead, we want to check what's in production and ensure that it has no issues. We'll run this new workflow nightly (once a day) and check for any issues. This way, we can stay on top of the Docker image and fix things sooner.Fixes #4903