refactor: remove folder/workspace from vsCodeCliArgs #4932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #4932 deployed! It will be updated on every commit.
|
jsjoeio
force-pushed
the
jsjoeio/fix-folder-workspace-cli-args
branch
from
aa44e6c to
6be88d7
Compare
28 tasks
jsjoeio
force-pushed
the
jsjoeio/fix-folder-workspace-cli-args
branch
from
6be88d7 to
c2ecce1
Compare
|
Argh, this won't pass CI until I remove those args in the VS Code side, merge and then update here. |
code-asher
reviewed
Mar 2, 2022
code-asher
approved these changes
Mar 2, 2022
Since we handle this in the vscode.ts route, we no longer need to pass it to VS Code as a CLI arg since it's deprecated on that side.
Co-authored-by: Asher <[email protected]>
jsjoeio
force-pushed
the
jsjoeio/fix-folder-workspace-cli-args
branch
from
1cd9aa8 to
4ffd923
Compare
code-asher
reviewed
Mar 2, 2022
Co-authored-by: Asher <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4932 +/- ##
==========================================
+ Coverage 70.16% 70.29% +0.13%
==========================================
Files 29 29
Lines 1666 1670 +4
Branches 369 369
==========================================
+ Hits 1169 1174 +5
+ Misses 423 422 -1
Partials 74 74
Continue to review full report at Codecov.
|
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* refactor: remove folder/workspace from vsCodeCliArgs Since we handle this in the vscode.ts route, we no longer need to pass it to VS Code as a CLI arg since it's deprecated on that side. * feat(vscode): redirect to folder from cli * Update src/node/routes/vscode.ts Co-authored-by: Asher <[email protected]> * fixup!: update _: type * fixup!: move vars to lower if block * fixup!: share redirect block * fixup!: mmove req.query.ew block into if * fixup!: refactor vscode tests * refactor: make vscode.ts logic easier to read * fixup!: fix broken tests and clean up logic * chore: upgrade vscode version * fixup!: delete unnecessary if closed block * Update src/node/routes/vscode.ts Co-authored-by: Asher <[email protected]> * fixup!: rename to FOLDER_OR_WORKSPACE_WAS_CLOSED Co-authored-by: Asher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we handle this in the vscode.ts route, we no longer need to pass it to VS
Code as a CLI arg since it's deprecated on that side.
This adds logic to our
vscoderoute handler to handle both folder and workspace paths passed in via the CLIFixes an issue related to coder/vscode#45
Blocked by coder/vscode#49