-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore: update vscode to 1.64 #4902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ Coder.com for PR #4902 deployed! It will be updated on every commit.
|
e6077cd
to
e48506e
Compare
Codecov Report
@@ Coverage Diff @@
## main #4902 +/- ##
==========================================
+ Coverage 70.54% 70.56% +0.01%
==========================================
Files 29 29
Lines 1677 1678 +1
Branches 371 372 +1
==========================================
+ Hits 1183 1184 +1
Misses 420 420
Partials 74 74
Continue to review full report at Codecov.
|
Looks like the E2E tests are failing due to a missing dependency: [2022-03-05T00:[19](https://github.com/coder/code-server/runs/5429719980?check_suite_focus=true#step:9:19):40.752Z] warn Cannot find module '../../vendor/modules/code-oss-dev/package.json'
Require stack:
- /home/runner/work/code-server/code-server/src/node/constants.ts
- /home/runner/work/code-server/code-server/src/node/util.ts
- /home/runner/work/code-server/code-server/test/utils/globalE2eSetup.ts
- /home/runner/work/code-server/code-server/test/node_modules/@playwright/test/lib/loader.js
- /home/runner/work/code-server/code-server/test/node_modules/@playwright/test/lib/cli.js
- /home/runner/work/code-server/code-server/test/node_modules/playwright-core/lib/cli/cli.js
- /home/runner/work/code-server/code-server/test/node_modules/playwright-core/cli.js
- /home/runner/work/code-server/code-server/test/node_modules/playwright/cli.js |
3980b85
to
8e628d5
Compare
Argh still failing. Might need your help looking at this again @code-asher |
How to reproduce locallyWe know that we can reproduce this issue Root causeWe thought it was the code-server/.github/workflows/ci.yaml Line 151 in 0f5d8d3
So either that's not it or it didn't rebuild vscode even though we changed the cache key. Looks like that didn't work. So we'll need to either temporarily disable cache or figure out something else. EDIT: I confused the cache key with the job id. Newest commit should fix it. Trying this solution too |
* chore: update vscode server files * chore: update code to 1.64 * refactor: clean up code in constants.ts * chore: keep package.json vscode cache * fixup!: formatting * feat(ci): add VSCODE_CACHE_VERSION * fix(ci): add package.json for e2e tests * fix: TS errors * refactor: remove isConnected e2e tests
Blocked by coder/vscode#45
TODOs
vendor/package.json
Fixes #4822
Fixes #4725 (see #4725 (comment))