chore: update vscode commit #4857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes two fixes from coder/vscode: - coder/vscode#43 - coder/vscode#42
code-asher
approved these changes
Feb 11, 2022
|
✨ Coder.com for PR #4857 deployed! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #4857 +/- ##
=======================================
Coverage 69.72% 69.72%
=======================================
Files 29 29
Lines 1645 1645
Branches 363 363
=======================================
Hits 1147 1147
Misses 424 424
Partials 74 74 Continue to review full report at Codecov.
|
|
I realized why this was failing...this updates VS Code which includes a fix with two curly brackets for the proxy URL. That means we must also update the e2e test. Done and pushed |
Looks like I'll need to fix this tomorrow |
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* chore: update vscode commit This includes two fixes from coder/vscode: - coder/vscode#43 - coder/vscode#42 * fix: use double-bracket in ext. e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two fixes from coder/vscode:
Fixes N/A