Skip to content

chore: allow overwriting Docker images #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

chore: allow overwriting Docker images #4850

merged 1 commit into from
Feb 11, 2022

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Feb 11, 2022

Allow Docker images to be overwritten, which is required to update
dependencies in the base image when the upstream vendor resolves
security issues.

@jawnsy
chore: allow overwriting Docker images
fc8a2fe 
Allow Docker images to be overwritten, which is required to update
dependencies in the base image when the upstream vendor resolves
security issues.
@jawnsy jawnsy temporarily deployed to CI February 11, 2022 01:44 Inactive
@jawnsy jawnsy self-assigned this Feb 11, 2022
@jawnsy jawnsy marked this pull request as ready for review February 11, 2022 01:47
@jawnsy jawnsy requested a review from a team February 11, 2022 01:47
@github-actions
Copy link

✨ Coder.com for PR #4850 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #4850 (fc8a2fe) into main (8135d2e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4850   +/-   ##
=======================================
  Coverage   69.17%   69.17%           
=======================================
  Files          29       29           
  Lines        1645     1645           
  Branches      363      363           
=======================================
  Hits         1138     1138           
  Misses        430      430           
  Partials       77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8135d2e...fc8a2fe. Read the comment docs.

jsjoeio
jsjoeio approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! @code-asher any concerns?

@jawnsy jawnsy requested a review from code-asher February 11, 2022 16:52
code-asher
code-asher approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jawnsy jawnsy merged commit 03c6224 into main Feb 11, 2022
@jawnsy jawnsy deleted the jawnsy/chore-allow-overwrite branch February 11, 2022 17:32
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@jawnsy @TinLe
chore: allow overwriting Docker images (coder#4850)
15be9b3 
Allow Docker images to be overwritten, which is required to update
dependencies in the base image when the upstream vendor resolves
security issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@code-asher code-asher code-asher approved these changes

Assignees

@jawnsy jawnsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawnsy @jsjoeio @code-asher