feat: Add support for ingressClassName in Helm Chart #4844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
reviewed
Feb 10, 2022
jawnsy
approved these changes
Feb 10, 2022
Matthew-Beckett
approved these changes
Feb 10, 2022
jawnsy
reviewed
Feb 10, 2022
|
Thanks @jsjoeio, @jawnsy, and @Matthew-Beckett. Feedback integrated into the latest commit. |
Co-authored-by: Jonathan Yu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4844 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 29 29
Lines 1645 1645
Branches 363 363
=======================================
Hits 1138 1138
Misses 430 430
Partials 77 77 Continue to review full report at Codecov.
|
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
Allow configuring the ingress class via a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #NA - No issue created due to minor nature of change.
This adds an optional parameter to the ingress object for
ingressClassNamewhich is available in K8s 1.18+. More information oningressClassNamecan be found here.Please let me know if you need any more information or other changes. I did a minor version bump for the chart, but happy to remove that if needed.