Skip to content

fix(ci): add environment to docs-preview #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 4, 2022

This PR updates the docs-preview.yaml workflow to use an environment which should have the correct secrets for deploying a docs preview.

Fixes #4027

@jsjoeio jsjoeio added docs Documentation related ci Issues related to ci labels Jan 4, 2022
@jsjoeio jsjoeio self-assigned this Jan 4, 2022
@jsjoeio jsjoeio requested a review from a team January 4, 2022 17:05
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 4, 2022

I'm not sure what is going wrong here:
image

I'll need to further investigate

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 4, 2022

@jawnsy and I discussed this. We're not sure why it's failing. We think merging it might fix so we're going to try that.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #4677 (f18474f) into main (0034808) will not change coverage.
The diff coverage is n/a.

❗ Current head f18474f differs from pull request most recent head 39b2ac8. Consider uploading reports for the commit 39b2ac8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4677   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files          29       29           
  Lines        1638     1638           
  Branches      341      341           
=======================================
  Hits         1132     1132           
  Misses        430      430           
  Partials       76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0034808...39b2ac8. Read the comment docs.

@jsjoeio jsjoeio merged commit 7695de2 into coder:main Jan 4, 2022
@jsjoeio jsjoeio deleted the fix-ci-docs-workflow branch January 4, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to ci docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate changing docs preview workflow
2 participants