Add confirmation for closing window #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
requested changes
Apr 8, 2019
kylecarbs
requested changes
Apr 9, 2019
sr229
suggested changes
Apr 10, 2019
code-asher
reviewed
Apr 11, 2019
code-asher
approved these changes
Apr 11, 2019
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
* Add confirmation for closing window * Make function an event listener for consistency * Change let to const * Refactor for compatability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
Control W closes the browser window instantly without respect for unsaved work. This shows a prompt asking if you want to leave.
Is there an open issue you can link to?
#53