Skip to content

Add Instructions To Install 100% In Android #4536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2021
Merged

Add Instructions To Install 100% In Android #4536

merged 3 commits into from
Dec 14, 2021

Conversation

thealidev
Copy link
Contributor

Thx

Fixes #

@thealidev thealidev requested a review from a team as a code owner November 21, 2021 05:23
thealidev
thealidev commented Nov 21, 2021
View reviewed changes
Copy link
Contributor Author

@thealidev thealidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Will Install 100% Code Server In Your Android Phone

jsjoeio
jsjoeio suggested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this! 🎉

I guess this wouldn't fall under the Termux docs since it uses userland. I have some minor requests about formatting but generally, this looks great!

(note to self: I'll probably need to refactor and combine some stuff later)

docs/android.md
Comment on lines +2 to +6
📱-Install Userland From Playstore First
📱-Install Ubuntu VM
📱-Start It
📱-Install NodeJS, Curl And Yarn Using `sudo apt install nodejs npm yarn curl -y`
📱-Install NVM :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to a numbered list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofc

This comment was marked as off-topic.

Sign in to view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let me know after you fix it and then we can get this merged!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not termux
It’s userland on playstore

docs/android.md
Comment on lines +10 to +11
📱-Then Exit Terminal Using `exit` and then reopen terminal
📱Then Run This To Install And Use NodeJS 14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofc by code server node js version required

@jsjoeio jsjoeio self-assigned this Nov 29, 2021
@jsjoeio jsjoeio mentioned this pull request Nov 30, 2021
Closed
@thealidev
Copy link
Contributor Author

If you want to add some other docs then i can help
I doesn't know much languages
I used every type of linux in android

jsjoeio
jsjoeio suggested changes Dec 6, 2021
View reviewed changes
docs/android.md
Comment on lines +2 to +6
📱-Install Userland From Playstore First
📱-Install Ubuntu VM
📱-Start It
📱-Install NodeJS, Curl And Yarn Using `sudo apt install nodejs npm yarn curl -y`
📱-Install NVM :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let me know after you fix it and then we can get this merged!

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 6, 2021

If you want to add some other docs then i can help

Thank you for offering that! Let's get this updated and merged and then discuss other doc improvements ♥️

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 8, 2021

Still waiting on those changes before we can review and merge this! Going to push to the next release.

@jsjoeio jsjoeio added this to the 4.0.1 milestone Dec 8, 2021
@thealidev
Copy link
Contributor Author

ABA3FECD-1F8A-42C9-AE99-B9DC0382D761
I didn't use fmt with yarn !!

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 13, 2021

@alixgamer175 do you know if you hit "Allow edit from maintainers"? If so, I can fix this for you

@jsjoeio jsjoeio modified the milestones: 4.0.1, 4.0.0 Dec 13, 2021
@thealidev
Copy link
Contributor Author

F0D5C7A7-E069-4701-987B-74D142C02F89

Done

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 14, 2021

There are some doc changes I want to make to this so here's what I'm going to do.

  1. create a new branch based off main
  2. update this PR to PR into that branch
  3. make changes
  4. merge into main

That way we can fix these errors and get this in 👍

@jsjoeio jsjoeio changed the base branch from main to jsjoeio-fix-android-docs December 14, 2021 22:18
@jsjoeio jsjoeio merged commit 711e62b into coder:jsjoeio-fix-android-docs Dec 14, 2021
@jsjoeio jsjoeio mentioned this pull request Dec 14, 2021
Merged
jsjoeio added a commit that referenced this pull request Dec 15, 2021
@jsjoeio
Add Instructions To Install 100% In Android (#4536)
70e0b35 
* Add Instructions To Install 100% In Android

Thx

* Update android.md

Co-authored-by: Joe Previte <[email protected]>
@im-coder-lg
Copy link
Contributor

Well, clone the repo locally/use Gitpod, and install the dependencies. After that, run yarn fmt. Hope I'm right, @jsjoeio is there more to the FMT?

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 15, 2021

there more to the FMT?

Just need to clean up a few things so yes, but I think it's all good now!

jsjoeio added a commit that referenced this pull request Dec 15, 2021
@jsjoeio
Add Instructions To Install 100% In Android (#4536)
7eb1a08 
* Add Instructions To Install 100% In Android

Thx

* Update android.md

Co-authored-by: Joe Previte <[email protected]>
repo-ranger bot added a commit that referenced this pull request Dec 15, 2021
@jsjoeio @code-asher @repo-ranger
docs: add section for Android (#4621)
3059d72 
* Add Instructions To Install 100% In Android (#4536)

* Add Instructions To Install 100% In Android

Thx

* Update android.md

Co-authored-by: Joe Previte <[email protected]>

* docs: clean up android.md

* docs: add android to manifest

* Add missing backtick

Co-authored-by: The AliX Legend <[email protected]>
Co-authored-by: Asher <[email protected]>
Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-coder-lg im-coder-lg im-coder-lg left review comments

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@thealidev @jsjoeio @im-coder-lg