Skip to content

Fix issue where 404 errors are mistaken for server errors. #4534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

GirlBossRush
Copy link
Contributor

Fixes #4521

Related: coder/vscode@a1d3f91

@GirlBossRush GirlBossRush added the bug Something isn't working label Nov 19, 2021
@GirlBossRush GirlBossRush added this to the 4.0.0 milestone Nov 19, 2021
@GirlBossRush GirlBossRush self-assigned this Nov 19, 2021
@GirlBossRush GirlBossRush requested a review from a team as a code owner November 19, 2021 21:43
@GirlBossRush GirlBossRush mentioned this pull request Nov 19, 2021
@github-actions
Copy link

github-actions bot commented Nov 19, 2021

✨ Coder.com for PR #4534 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #4534 (9ee5924) into main (db35c47) will decrease coverage by 0.05%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4534      +/-   ##
==========================================
- Coverage   65.44%   65.38%   -0.06%     
==========================================
  Files          30       30              
  Lines        1658     1664       +6     
  Branches      333      335       +2     
==========================================
+ Hits         1085     1088       +3     
- Misses        487      488       +1     
- Partials       86       88       +2     
Impacted Files Coverage Δ
src/node/routes/errors.ts 82.75% <72.72%> (-8.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db35c47...9ee5924. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me! Nice work! 🔥

@GirlBossRush GirlBossRush merged commit bd09533 into main Nov 19, 2021
@GirlBossRush GirlBossRush deleted the 4521-errors branch November 19, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404s are reported as 500s
2 participants