Skip to content

Update VS Code #4494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ implementation (#4414).
vscode-remote-resource endpoint still can.
- OpenVSX has been made the default marketplace. However this means web
extensions like Vim are now broken.
- The proposed API has been defaulted to on. As a result the
`--enable-proposed-api` flag has been removed.

## [3.12.0](https://github.com/cdr/code-server/releases/tag/v3.12.0) - 2021-09-15

Expand Down
10 changes: 1 addition & 9 deletions docs/collaboration.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,4 @@ As `code-server` is based on VS Code, you can follow the steps described on Duck
code-server --install-extension genuitecllc.codetogether
```

2. CodeTogether requires VS Code's proposed API to run. Start code-server with the following flag:

```sh
code-server --enable-proposed-api genuitecllc.codetogether
```

Another option would be to add a value in code-server's [config file](https://coder.com/docs/code-server/v3.12.0/FAQ#how-does-the-config-file-work).

3. Refresh code-server and navigate to the CodeTogether icon in the sidebar to host or join a coding session.
2. Refresh code-server and navigate to the CodeTogether icon in the sidebar to host or join a coding session.
6 changes: 0 additions & 6 deletions src/node/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ export interface UserProvidedArgs {
"disable-telemetry"?: boolean
force?: boolean
"user-data-dir"?: string
"enable-proposed-api"?: string[]
"extensions-dir"?: string
"builtin-extensions-dir"?: string
"install-extension"?: string[]
Expand Down Expand Up @@ -196,11 +195,6 @@ const options: Options<Required<UserProvidedArgs>> = {
"Install or update a VS Code extension by id or vsix. The identifier of an extension is `${publisher}.${name}`.\n" +
"To install a specific version provide `@${version}`. For example: '[email protected]'.",
},
"enable-proposed-api": {
type: "string[]",
description:
"Enable proposed API features for extensions. Can receive one or more extension IDs to enable individually.",
},
"uninstall-extension": { type: "string[]", description: "Uninstall a VS Code extension by id." },
"show-versions": { type: "boolean", description: "Show VS Code extension versions." },
"proxy-domain": { type: "string[]", description: "Domain used for proxying ports." },
Expand Down
4 changes: 2 additions & 2 deletions test/unit/node/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,9 @@ describe("cli", () => {

describe("splitOnFirstEquals", () => {
it("should split on the first equals", () => {
const testStr = "enabled-proposed-api=test=value"
const testStr = "proxy-domain=test=value"
const actual = splitOnFirstEquals(testStr)
const expected = ["enabled-proposed-api", "test=value"]
const expected = ["proxy-domain", "test=value"]
expect(actual).toEqual(expect.arrayContaining(expected))
})
it("should split on first equals regardless of multiple equals signs", () => {
Expand Down