Skip to content

Update changelog #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Update changelog #4492

merged 1 commit into from
Nov 10, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Nov 10, 2021

I added the missing versions and some changelog entries for the latest
version. I also added some extra details to the entries that should
help users understand what changed and what they need to do about
it. The overall format is based on keepachangelog.com.

In that same spirit I removed entries that do not affect
users (documentation and development changes).

I removed the names because it seems unlikely users will be interested,
that information can be found in the PR, and code is really the work of
multiple developers (even if only one is writing code and the other is
reviewing) which is not something that is reflected in this document.

Please feel free to debate the changes!

@code-asher code-asher requested a review from a team as a code owner November 10, 2021 21:59
I added the missing versions and some changelog entries for the latest
version.  I also added some extra details to the entries that should
help users understand what changed and what they need to do about
it.  The overall format is based on keepachangelog.com.

In that same spirit I removed entries that do not affect
users (documentation and development changes).

I removed the names because it seems unlikely users will be interested,
that information can be found in the PR, and code is really the work of
multiple developers (even if only one is writing code and the other is
reviewing) which is not something that is reflected in this document.
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #4492 (a1a4ce4) into main (e4a797d) will not change coverage.
The diff coverage is n/a.

❗ Current head a1a4ce4 differs from pull request most recent head 69b7807. Consider uploading reports for the commit 69b7807 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4492   +/-   ##
=======================================
  Coverage   66.46%   66.46%           
=======================================
  Files          30       30           
  Lines        1625     1625           
  Branches      330      330           
=======================================
  Hits         1080     1080           
  Misses        463      463           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a797d...69b7807. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for this! I agree, they can find the user in the PR (and PRs have multiple authors as you mentioned). Seems like a step forward for us! 🎉

@code-asher code-asher merged commit d052cc2 into coder:main Nov 10, 2021
@code-asher code-asher deleted the update-changelog branch November 10, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants