Skip to content

chore: update vscode #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: update vscode #4440

wants to merge 1 commit into from

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Nov 3, 2021

This PR updates VS Code after @code-asher pushed a fix to our fork related to the build

Related #4436

@jsjoeio jsjoeio requested a review from a team as a code owner November 3, 2021 20:35
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

✨ Coder.com for PR #4440 deployed! It will be updated on every commit.

@jsjoeio jsjoeio force-pushed the jsjoeio-update-vscode branch from cfc1609 to 94c3fb8 Compare November 3, 2021 20:54
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 3, 2021

Will update after coder/vscode#10 is merged

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #4440 (c5c535c) into main (03651e5) will not change coverage.
The diff coverage is n/a.

❗ Current head c5c535c differs from pull request most recent head 05a3493. Consider uploading reports for the commit 05a3493 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4440   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files          30       30           
  Lines        1602     1602           
  Branches      315      315           
=======================================
  Hits         1058     1058           
  Misses        466      466           
  Partials       78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03651e5...05a3493. Read the comment docs.

@jsjoeio jsjoeio force-pushed the jsjoeio-update-vscode branch from 94c3fb8 to 7b749fc Compare November 3, 2021 21:20
@jsjoeio jsjoeio self-assigned this Nov 3, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 3, 2021

@code-asher nooo! What am I doing wrong? Think it's cached?

    browserType.launch: Failed to launch webkit because executable doesn't exist at /home/runner/.cache/ms-playwright/webkit-1492/pw_run.sh
    Try re-installing playwright with "npm install playwright"

@jsjoeio jsjoeio force-pushed the jsjoeio-update-vscode branch from 7b749fc to 05a3493 Compare November 4, 2021 17:57
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 9, 2021

This is old...we've updated VS Code in other PRs so closing this.

@jsjoeio jsjoeio closed this Nov 9, 2021
@jsjoeio jsjoeio deleted the jsjoeio-update-vscode branch November 9, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants