Skip to content

Avoid npx for Playwright dependencies #4437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Avoid npx for Playwright dependencies #4437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,6 @@ jobs:
with:
node-version: "14"

- name: Install playwright OS dependencies
run: npx playwright install-deps

- name: Fetch dependencies from cache
id: cache-yarn
uses: actions/cache@v2
Expand All @@ -406,14 +403,8 @@ jobs:
if: steps.cache-yarn.outputs.cache-hit != 'true'
run: yarn --frozen-lockfile

# HACK: this shouldn't need to exist, but put it here anyway
# in an attempt to solve Playwright cache failures.
- name: Reinstall playwright
if: steps.cache-yarn.outputs.cache-hit == 'true'
run: |
cd test/
rm -r node_modules/playwright
yarn install --check-files
- name: Install Playwright OS dependencies
run: ./test/node_modules/.bin/playwright install-deps

- name: Run end-to-end tests
run: yarn test:e2e
Expand Down