-
Notifications
You must be signed in to change notification settings - Fork 5.9k
refactor(ci): only run release workflows on released event #4288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✨ Coder.com for PR #4288 deployed! It will be updated on every commit.
|
waiting on #4290 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very interesting
dbad8cb
to
0046cea
Compare
The build is failing and I'm not sure why. See logs. I'm going to investigate. |
cfeed70
to
b2be04d
Compare
Codecov Report
@@ Coverage Diff @@
## main #4288 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 31 31
Lines 1620 1620
Branches 316 316
=======================================
Hits 1074 1074
Misses 468 468
Partials 78 78 Continue to review full report at Codecov.
|
b2be04d
to
872bb81
Compare
This PR updates the trigger event for both the "Publish on npm and brew" and the "Publish on Docker" release workflows so that they only run on
released
(instead ofpublished
).Why is this change necessary?
In order for us to publish pre-releases without triggering these workflows, this change needs to happen.
We learned this through the GitHub Actions docs:
Fixes N/A
Related #4264