Skip to content

refactor(ci): only run release workflows on released event #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 1, 2021

This PR updates the trigger event for both the "Publish on npm and brew" and the "Publish on Docker" release workflows so that they only run on released (instead of published).

Why is this change necessary?

In order for us to publish pre-releases without triggering these workflows, this change needs to happen.

We learned this through the GitHub Actions docs:

Note: The prereleased type will not trigger for pre-releases published from draft releases, but the published type will trigger. If you want a workflow to run when stable and pre-releases publish, subscribe to published instead of released and prereleased.

Fixes N/A
Related #4264

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Oct 1, 2021
@jsjoeio jsjoeio self-assigned this Oct 1, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner October 1, 2021 18:57
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

✨ Coder.com for PR #4288 deployed! It will be updated on every commit.

@jsjoeio jsjoeio marked this pull request as draft October 1, 2021 19:24
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 1, 2021

waiting on #4290

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very interesting

@jsjoeio jsjoeio force-pushed the jsjoeio-update-publish-workflows branch from dbad8cb to 0046cea Compare October 1, 2021 22:20
@jsjoeio jsjoeio marked this pull request as ready for review October 1, 2021 22:37
@jsjoeio jsjoeio marked this pull request as draft October 1, 2021 22:56
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 1, 2021

The build is failing and I'm not sure why. See logs. I'm going to investigate.

image

@jsjoeio jsjoeio force-pushed the jsjoeio-update-publish-workflows branch 2 times, most recently from cfeed70 to b2be04d Compare October 4, 2021 21:32
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #4288 (872bb81) into main (946e4e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4288   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files          31       31           
  Lines        1620     1620           
  Branches      316      316           
=======================================
  Hits         1074     1074           
  Misses        468      468           
  Partials       78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946e4e8...872bb81. Read the comment docs.

@jsjoeio jsjoeio force-pushed the jsjoeio-update-publish-workflows branch from b2be04d to 872bb81 Compare October 29, 2021 23:26
@jsjoeio jsjoeio marked this pull request as ready for review October 29, 2021 23:29
@jsjoeio jsjoeio merged commit 743bab0 into main Nov 1, 2021
@jsjoeio jsjoeio deleted the jsjoeio-update-publish-workflows branch November 1, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants