Skip to content

feat(cli): add test for defaultConfigFile #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2021
Merged

feat(cli): add test for defaultConfigFile #4265

merged 4 commits into from
Sep 28, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 28, 2021 •
edited
Loading

This PR adds a test for defaultConfigFile in src/node/cli.ts.

image

Fixes N/A

TODOS

  • export function
  • add JSDoc block to function
  • write basic test

@jsjoeio jsjoeio self-assigned this Sep 28, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label Sep 28, 2021
@github-actions
Copy link

github-actions bot commented Sep 28, 2021 •
edited
Loading

✨ Coder.com for PR #4265 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #4265 (6c95f72) into main (8f72481) will increase coverage by 0.23%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4265      +/-   ##
==========================================
+ Coverage   65.09%   65.32%   +0.23%     
==========================================
  Files          36       36              
  Lines        1882     1883       +1     
  Branches      380      380              
==========================================
+ Hits         1225     1230       +5     
+ Misses        559      555       -4     
  Partials       98       98
Impacted Files Coverage Δ
src/node/cli.ts 81.48% <33.33%> (+0.48%) ⬆️
src/node/util.ts 83.24% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f72481...6c95f72. Read the comment docs.

@jsjoeio jsjoeio marked this pull request as ready for review September 28, 2021 22:53
@jsjoeio jsjoeio requested a review from a team as a code owner September 28, 2021 22:53
bryphe-coder
bryphe-coder approved these changes Sep 28, 2021
View reviewed changes
Copy link

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsjoeio jsjoeio enabled auto-merge September 28, 2021 23:13
@jsjoeio jsjoeio merged commit 1b80244 into main Sep 28, 2021
@jsjoeio jsjoeio deleted the jsjoeio-add-tests branch September 28, 2021 23:19
greyscaled
greyscaled reviewed Sep 29, 2021
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled left review comments

@bryphe-coder bryphe-coder bryphe-coder approved these changes

Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
4.0.0 - pre-release
Development

Successfully merging this pull request may close these issues.
3 participants
@jsjoeio @greyscaled @bryphe-coder