Skip to content

fix(codecov): use status > patch correctly #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 13, 2021

I thought I fixed this in a previous PR but I guess not. I can't seem to find it. Turns out, our codecov was technically invalid because we weren't using patch: off under status.

To prevent this in the future, validate the codecov:

cd .github && curl --data-binary @codecov.yml https://codecov.io/validate

Fixes N/A

@jsjoeio jsjoeio added testing Anything related to testing chore Related to maintenance or clean up labels Sep 13, 2021
@jsjoeio jsjoeio added this to the 3.12.0 milestone Sep 13, 2021
@jsjoeio jsjoeio self-assigned this Sep 13, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner September 13, 2021 20:55
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #4159 (030f657) into main (bc3acb0) will not change coverage.
The diff coverage is n/a.

❗ Current head 030f657 differs from pull request most recent head 14c9616. Consider uploading reports for the commit 14c9616 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4159   +/-   ##
=======================================
  Coverage   64.22%   64.22%           
=======================================
  Files          36       36           
  Lines        1873     1873           
  Branches      379      379           
=======================================
  Hits         1203     1203           
  Misses        569      569           
  Partials      101      101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3acb0...14c9616. Read the comment docs.

@github-actions
Copy link

✨ Coder.com for PR #4159 deployed! It will be updated on every commit.

Copy link

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me! 👍

@jsjoeio jsjoeio merged commit 674f37f into main Sep 14, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-codecov-config branch September 14, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants