Skip to content

Remove subtree #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove subtree #4136

wants to merge 2 commits into from

Conversation

GirlBossRush
Copy link
Contributor

This PR should be merged after #4135, which migrates the app to a vendor package.

@GirlBossRush
Add vscode via vendor package.
2e106cc 
- Remove asar linking.
- Remove module lint check.
- Use yarn for vscode vendoring.
@GirlBossRush
Remove subtree.
500f722
@GirlBossRush GirlBossRush added the chore Related to maintenance or clean up label Sep 10, 2021
@GirlBossRush GirlBossRush added this to the 3.12.0 milestone Sep 10, 2021
@GirlBossRush GirlBossRush self-assigned this Sep 10, 2021
@GirlBossRush GirlBossRush requested a review from a team as a code owner September 10, 2021 16:41
@GirlBossRush GirlBossRush mentioned this pull request Sep 10, 2021
Merged
@github-actions
Copy link

✨ Coder.com for PR #4136 deployed! It will be updated on every commit.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 10, 2021

This PR should be merged after #4135, which migrates the app to a vendor package.

What if we merge this into vscode-1.60.0-yarn (#4135's branch) instead of into main? That way, we don't accidentally merge this and those two land in main together since they depend on each other. Just a thought

@GirlBossRush
Copy link
Contributor Author

This PR should be merged after #4135, which migrates the app to a vendor package.

What if we merge this into vscode-1.60.0-yarn (#4135's branch) instead of into main? That way, we don't accidentally merge this and those two land in main together since they depend on each other. Just a thought

I believe if we merge in that direction then the diff vscode-1.60.0-yarn will be unreadable as it’ll contain its files as well as the many deletions present here.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 10, 2021

This PR should be merged after #4135, which migrates the app to a vendor package.

What if we merge this into vscode-1.60.0-yarn (#4135's branch) instead of into main? That way, we don't accidentally merge this and those two land in main together since they depend on each other. Just a thought

I believe if we merge in that direction then the diff vscode-1.60.0-yarn will be unreadable as it’ll contain its files as well as the many deletions present here.

Ahh...didn't consider that. Okay, sounds like you have the best plan in mind already! Ignore me :)

@GirlBossRush GirlBossRush modified the milestones: 3.12.0, 3.12.1 Sep 10, 2021
@jsjoeio jsjoeio deleted the remove-subtree branch March 22, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio Awaiting requested review from jsjoeio

@code-asher code-asher Awaiting requested review from code-asher

Assignees

@GirlBossRush GirlBossRush

Labels
chore Related to maintenance or clean up
Projects
None yet
Milestone
3.12.1 - improve release process
Development

Successfully merging this pull request may close these issues.
2 participants
@GirlBossRush @jsjoeio