Skip to content

feat: add tests for src/node/app.ts #4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021
Merged

feat: add tests for src/node/app.ts #4099

merged 1 commit into from
Sep 10, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 3, 2021

This adds a couple tests for ensureAddress.

(Note: related to #4094. I still need to add more tests to complete the issue but will do so in separate PRs.)

@jsjoeio jsjoeio requested a review from a team as a code owner September 3, 2021 19:02
@jsjoeio jsjoeio self-assigned this Sep 3, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label Sep 3, 2021
@jsjoeio jsjoeio added this to the 3.12.0 milestone Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #4099 (0944056) into main (8a1c129) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4099      +/-   ##
==========================================
+ Coverage   64.12%   64.22%   +0.10%     
==========================================
  Files          36       36              
  Lines        1873     1873              
  Branches      379      379              
==========================================
+ Hits         1201     1203       +2     
+ Misses        571      569       -2     
  Partials      101      101              
Impacted Files Coverage Δ
src/node/app.ts 73.80% <100.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1c129...0944056. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

✨ Coder.com for PR #4099 deployed! It will be updated on every commit.

This adds a couple tests for ensureAddress.
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are always nice 👍

@jsjoeio jsjoeio merged commit 9c9883e into main Sep 10, 2021
@jsjoeio jsjoeio deleted the jsjoeio-tests-app branch September 10, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants