-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix(revert): move helm README to docs #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4044 +/- ##
=======================================
Coverage 64.22% 64.22%
=======================================
Files 36 36
Lines 1873 1873
Branches 379 379
=======================================
Hits 1203 1203
Misses 569 569
Partials 101 101 Continue to review full report at Codecov.
|
✨ Coder.com for PR #4044 deployed! It will be updated on every commit.
|
Note to self: we think this is caused by handlerbars (in the markdown parsing used on coder com ). Going to leave this open for now and address once we fix upstream |
@jsjoeio I added table support on this PR https://github.com/cdr/m/pull/9700, but I noticed a few things:
|
@jsjoeio I wrapped the badges in links like GH does so they are displayed inline. GH code screenshot: |
Sure! I just copied this over so I have no preference
Hmm...I'm going to ask @jawnsy about that because there may be a reason we need to keep it |
fe05e2e
to
ce0c2cd
Compare
Hmmm...something is not right here https://codercom-enql9v6o6-codercom.vercel.app/docs/code-server/latest |
@jsjoeio I checked the Inspect page (link shows up in the build/deploy output), it still shows that there's something wrong with the curly braces {} -- @bpmct did you merge the handlebars removal change?
|
doesn't look like it 😢 |
Taking a look at why the check returns an error but the action is returning green. |
I re-run the check job and now it is working. Idk if it was using an old version of the script 🤔 |
🤷♂️ I'll keep an eye out. @BrunoQuaresma can we merge https://github.com/cdr/m/pull/9696? |
ce0c2cd
to
f84614b
Compare
@jsjoeio yeap! That is good for me. |
I need to double-check this branch. I think I messed it up yesterday when I thought I was on another branch. |
f84614b
to
49adba0
Compare
This reverts commit f319fca.
49adba0
to
d650894
Compare
This reverts the revert now that we fixed the upstream issue with the docs.
Fixes N/A
TODOs
helm.md
should be under Install