Skip to content

Revert "refactor: move helm README to docs/helm.md" #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 25, 2021

We think moving this broke the docs workflow

@jsjoeio jsjoeio requested a review from a team as a code owner August 25, 2021 19:03
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #4043 (f319fca) into main (c913386) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4043   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c913386...f319fca. Read the comment docs.

@github-actions
Copy link

✨ Coder.com for PR #4043 deployed! It will be updated on every commit.

@jsjoeio jsjoeio merged commit 070a122 into main Aug 25, 2021
@jsjoeio jsjoeio deleted the jsjoeio-revert-helm branch August 25, 2021 19:09
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 25, 2021

Note: we did not fully wait for CI to complete because this is a simple revert. We noticed this fixed the docs issue so we merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants