Skip to content

[#4013] backported https://github.com/microsoft/vscode/pull/131408 #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

sdissegna-maystreet
Copy link
Contributor

Fixes #4013

@sdissegna-maystreet sdissegna-maystreet requested a review from a team as a code owner August 25, 2021 07:23
@GirlBossRush GirlBossRush enabled auto-merge (rebase) August 25, 2021 13:01
@GirlBossRush
Copy link
Contributor

Thank you for a detailed breakdown of the issue. We’ll have to get aligned with upstream soon!

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #4038 (d26858b) into main (3e55e5e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4038   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e55e5e...d26858b. Read the comment docs.

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 25, 2021

Everything looks good!

We have a small issue with the docs preview (see #4027) so we can merge this

@jsjoeio jsjoeio disabled auto-merge August 25, 2021 17:28
@jsjoeio jsjoeio merged commit 15b39e6 into coder:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating or opening a new notebook with vscode-jupyter extension sometimes hangs
3 participants