Skip to content

refactor: update image in readme #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

refactor: update image in readme #4036

merged 1 commit into from
Aug 25, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 24, 2021

Updates the main image used in the README, specifically removing any mention of the code-server or VS Code version so that it doesn't get outdated

Fixes #3843

@jsjoeio jsjoeio requested a review from a team as a code owner August 24, 2021 23:17
@jsjoeio jsjoeio self-assigned this Aug 24, 2021
@jsjoeio jsjoeio added the docs Documentation related label Aug 24, 2021
@jawnsy
Copy link
Contributor

jawnsy commented Aug 24, 2021

This makes sense to me. Do we have an SVG version of this image?

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #4036 (547ca5e) into main (bc3fb5e) will not change coverage.
The diff coverage is n/a.

❗ Current head 547ca5e differs from pull request most recent head 8cf6949. Consider uploading reports for the commit 8cf6949 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4036   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3fb5e...8cf6949. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 24, 2021

✨ Coder.com for PR #4036 deployed! It will be updated on every commit.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 24, 2021

Do we have an SVG version of this image?

No, but I can export from Figma I think and make one! Should I do that instead?

@jawnsy
Copy link
Contributor

jawnsy commented Aug 24, 2021

@jsjoeio SVGs are always nicer because they scale better and are smaller, plus we can do fancy animations like the Expo CLI project that I think you retweeted about once!

@GirlBossRush GirlBossRush enabled auto-merge (rebase) August 25, 2021 13:03
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 25, 2021

plus we can do fancy animations like the Expo CLI project that I think you retweeted about once!

WOW! I hadn't seen that before (their SVG, not the project). That is sooo cool!

Okay going to disable auto-merge, add as SVG then merge

@jsjoeio jsjoeio disabled auto-merge August 25, 2021 17:17
@jsjoeio jsjoeio force-pushed the jsjoeio-update-image branch from 2e684ea to 8cf6949 Compare August 25, 2021 17:20
@jsjoeio jsjoeio enabled auto-merge August 25, 2021 17:20
@jsjoeio jsjoeio merged commit c913386 into main Aug 25, 2021
@jsjoeio jsjoeio deleted the jsjoeio-update-image branch August 25, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update image in README
3 participants