Skip to content

docs: add proxying a vue app #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2021
Merged

docs: add proxying a vue app #4033

merged 1 commit into from
Aug 24, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 24, 2021

Special thanks to @abhinav1912 and @Blakeinstein for helping with this!

Fixes #3918

@jsjoeio jsjoeio requested a review from a team as a code owner August 24, 2021 22:41
@jsjoeio jsjoeio self-assigned this Aug 24, 2021
@jsjoeio jsjoeio added the docs Documentation related label Aug 24, 2021
@jsjoeio jsjoeio enabled auto-merge August 24, 2021 22:46
@github-actions
Copy link

github-actions bot commented Aug 24, 2021

✨ Coder.com for PR #4033 deployed! It will be updated on every commit.

@jsjoeio jsjoeio force-pushed the jsjoeio-docs-vuejs branch from a458dd3 to 8cf98ea Compare August 24, 2021 22:47
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #4033 (8cf98ea) into main (d0ca3ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4033   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ca3ae...8cf98ea. Read the comment docs.

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whooooo vuejs

@jsjoeio jsjoeio merged commit 4bb3175 into main Aug 24, 2021
@jsjoeio jsjoeio deleted the jsjoeio-docs-vuejs branch August 24, 2021 23:06
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 25, 2021

@nekomeowww I totally forgot to tag you on this but I added a bit about proxying Vue apps to our docs

@nekomeowww
Copy link

@nekomeowww I totally forgot to tag you on this but I added a bit about proxying Vue apps to our docs

Nah, it's fine. It was happy to see you guys update those documentations quickly and actively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for proxying Vue applications
3 participants