Skip to content

chore: add docs preview workflow #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021
Merged

chore: add docs preview workflow #3958

merged 1 commit into from
Aug 11, 2021

Conversation

BrunoQuaresma
Copy link
Contributor

Add a new workflow to generate docs preview. It is the same workflow used by Coder docs with some minor changes.

@BrunoQuaresma BrunoQuaresma requested a review from jawnsy August 11, 2021 18:10
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 11, 2021
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner August 11, 2021 18:10
@github-actions
Copy link

✨ Coder.com for PR #3958 deployed! It will be updated on every commit.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is awesome! 🙌

This makes it 1000x easier to preview new doc changes. Thanks @BrunoQuaresma ♥️

@jsjoeio jsjoeio added this to the 3.11.2 milestone Aug 11, 2021
@jsjoeio jsjoeio added chore Related to maintenance or clean up docs Documentation related labels Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #3958 (31373d8) into main (be0e5de) will increase coverage by 0.90%.
The diff coverage is 100.00%.

❗ Current head 31373d8 differs from pull request most recent head 90e6310. Consider uploading reports for the commit 90e6310 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3958      +/-   ##
==========================================
+ Coverage   62.60%   63.51%   +0.90%     
==========================================
  Files          36       36              
  Lines        1872     1872              
  Branches      379      379              
==========================================
+ Hits         1172     1189      +17     
+ Misses        595      580      -15     
+ Partials      105      103       -2     
Impacted Files Coverage Δ
src/browser/register.ts 100.00% <100.00%> (ø)
src/node/proxy_agent.ts 60.00% <100.00%> (+60.00%) ⬆️
src/node/proxy.ts 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0e5de...90e6310. Read the comment docs.

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 11, 2021

will increase coverage by 0.90%.

Totally unsure how this happened but won't complain 😄

@BrunoQuaresma
Copy link
Contributor Author

will increase coverage by 0.90%.

Totally unsure how this happened but won't complain 😄

LOL, me neither. My guess is the coverage is being calculated, including all the files. Maybe we can improve this one by excluding extensions unrelated to the app itsewlf, like .ymal and .md

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) August 11, 2021 18:27
@BrunoQuaresma BrunoQuaresma merged commit cee0e85 into main Aug 11, 2021
@BrunoQuaresma BrunoQuaresma deleted the add-docs-manifest branch August 11, 2021 18:33
@jsjoeio jsjoeio modified the milestones: 3.11.2, 3.12.0 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants