Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
publish-npm.sh
to add an.npmignore
with a line to exclude the symlinknode_modules.asar
in the npm release.Why are we doing this?
As you may have see in the 3.11.1 discussion, we had a hiccup publishing the latest version to npm/Homebrew. This is because npm recently made a change to their package requirements, disallowing symlinks in packages.
Fortunately, we don't need the symlink in the npm package release of code-server.
We originally thought we could remove the symlink all together, but after chatting with @code-asher, we realized we still need it for the standalone releases.
Fixing it
We had two options to fix it:
.gitignore
to the npm package before bundling up.npmignore
to the npm package and include the symlinkWe opted to go with Option 2 because:
publish-npm.sh
.gitignore
could have unintended consequences)Test plan
Screen.Recording.2021-08-11.at.10.59.36.AM.mov
Fixes N/A
Related: